-
Notifications
You must be signed in to change notification settings - Fork 24.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Transform] Enhance transform role checks #70139
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- warn if cluster lacks a transform node in all API's (except DELETE) - report waiting state in stats if transform waits for assignment - cancel p-task on stop transform even if config has been deleted relates elastic#69518
hendrikmuhs
force-pushed
the
transform-rolechecks
branch
from
March 9, 2021 11:26
ec7a4fd
to
9aedea4
Compare
Pinging @elastic/ml-core (Team:ML) |
przemekwitek
reviewed
Mar 9, 2021
...t-high-level/src/main/java/org/elasticsearch/client/transform/transforms/TransformStats.java
Show resolved
Hide resolved
x-pack/plugin/core/src/main/java/org/elasticsearch/xpack/core/transform/TransformMessages.java
Outdated
Show resolved
Hide resolved
.../plugin/transform/src/main/java/org/elasticsearch/xpack/transform/action/TransformNodes.java
Outdated
Show resolved
Hide resolved
...src/main/java/org/elasticsearch/xpack/transform/action/TransportGetTransformStatsAction.java
Show resolved
Hide resolved
...src/main/java/org/elasticsearch/xpack/transform/action/TransportGetTransformStatsAction.java
Outdated
Show resolved
Hide resolved
przemekwitek
approved these changes
Mar 10, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
with one question
...usterTest/java/org/elasticsearch/xpack/transform/integration/TransformNoTransformNodeIT.java
Outdated
Show resolved
Hide resolved
This was referenced Mar 10, 2021
Closed
hendrikmuhs
pushed a commit
that referenced
this pull request
Mar 10, 2021
hendrikmuhs
pushed a commit
that referenced
this pull request
Mar 10, 2021
improve robustness and ux in case of a missing transform node: - warn if cluster lacks a transform node in all API's (except DELETE) - report waiting state in stats if transform waits for assignment - cancel p-task on stop transform even if config has been deleted relates #69518
hendrikmuhs
pushed a commit
that referenced
this pull request
Mar 10, 2021
This was referenced Apr 27, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
improve robustness and ux in case of a missing transform node:
relates #69518