Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Transform] Enhance transform role checks #70139

Merged
merged 8 commits into from
Mar 10, 2021

Conversation

hendrikmuhs
Copy link

improve robustness and ux in case of a missing transform node:

  • warn if cluster lacks a transform node in all API's (except DELETE)
  • report waiting state in stats if transform waits for assignment
  • cancel p-task on stop transform even if config has been deleted

relates #69518

Hendrik Muhs added 3 commits March 9, 2021 12:26
 - warn if cluster lacks a transform node in all API's (except DELETE)
 - report waiting state in stats if transform waits for assignment
 - cancel p-task on stop transform even if config has been deleted

relates elastic#69518
@hendrikmuhs hendrikmuhs force-pushed the transform-rolechecks branch from ec7a4fd to 9aedea4 Compare March 9, 2021 11:26
@hendrikmuhs hendrikmuhs marked this pull request as ready for review March 9, 2021 11:54
@elasticmachine elasticmachine added the Team:ML Meta label for the ML team label Mar 9, 2021
@elasticmachine
Copy link
Collaborator

Pinging @elastic/ml-core (Team:ML)

Copy link
Contributor

@przemekwitek przemekwitek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

with one question

@hendrikmuhs hendrikmuhs merged commit 61f0c47 into elastic:master Mar 10, 2021
@hendrikmuhs hendrikmuhs deleted the transform-rolechecks branch March 10, 2021 09:17
hendrikmuhs pushed a commit that referenced this pull request Mar 10, 2021
hendrikmuhs pushed a commit that referenced this pull request Mar 10, 2021
improve robustness and ux in case of a missing transform node:

 - warn if cluster lacks a transform node in all API's (except DELETE)
 - report waiting state in stats if transform waits for assignment
 - cancel p-task on stop transform even if config has been deleted

relates #69518
hendrikmuhs pushed a commit that referenced this pull request Mar 10, 2021
finish backport of #70139: adapt versions and re-enable BWC
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants